[meta] exclude .gitmodules from npm package#340
Closed
kmosher wants to merge 1 commit into
Closed
Conversation
kmosher
force-pushed
the
fix/npmignore-gitmodules
branch
from
82bbf01 to
d4c03b1
Compare
Member
|
This was already done in 816c9e2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitmoduleswas accidentally included in the published tarball in the latest release — it's the git submodule config fortest/list-exports, which has no meaning outside of a git repo.This is breaking installation in Claude Code sandboxes, for reasons expounded on in the linked issue.
The actual
test/list-exportsdirectory is also already excluded after it was converted to a submodule. That change in itself might be contra the often cited goal of including the full set of tests in the package tarball for local offline inspection. Given.gitmodulesis just a GitHub URL though, its removal doesn't seem to make matters much worse on that front.Given the severity of the breakage, it might be worth re-releasing
2.0.0-next.6with the file stripped.Fixes #339.